Quantcast

about definition of struct _finddata_t

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

about definition of struct _finddata_t

Vincent Torri

Hey,

in io.h, shouldn't struct _finddata_t be guarded by _FINDDATA_T_DEFINED
(like _fsize_t is guarded by _FSIZE_T_DEFINED) ?

Vincent Torri


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Cegcc-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/cegcc-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: about definition of struct _finddata_t

Danny Backx
On Sun, 2009-08-23 at 18:18 +0200, Vincent Torri wrote:
> Hey,
>
> in io.h, shouldn't struct _finddata_t be guarded by _FINDDATA_T_DEFINED
> (like _fsize_t is guarded by _FSIZE_T_DEFINED) ?
>
> Vincent Torri

I guess so. Mingw doesn't appear to have this though. Does this bother
you or is it a cosmetic question ?

        Danny
--
Danny Backx ; danny.backx - at - scarlet.be ; http://danny.backx.info


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Cegcc-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/cegcc-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: about definition of struct _finddata_t

Vincent Torri


On Tue, 25 Aug 2009, Danny Backx wrote:

> On Sun, 2009-08-23 at 18:18 +0200, Vincent Torri wrote:
>> Hey,
>>
>> in io.h, shouldn't struct _finddata_t be guarded by _FINDDATA_T_DEFINED
>> (like _fsize_t is guarded by _FSIZE_T_DEFINED) ?
>>
>> Vincent Torri
>
> I guess so. Mingw doesn't appear to have this though. Does this bother
> you or is it a cosmetic question ?

It bother me a bit. It is for the compilation of Lua for Windows CE (Yes
it is possible !!). Indeed, the guy wrote some code to allow the
compilation of Lua on that OS, and used _FINDDATA_T_DEFINED around the
structure. Hence double definition of the structure when compiling.

Even it is not a problem for Lua on win32, I'll report that to the MinGW
devs.

Vincent Torri

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Cegcc-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/cegcc-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: about definition of struct _finddata_t

Danny Backx
On Wed, 2009-08-26 at 11:35 +0200, Vincent Torri wrote:

> On Tue, 25 Aug 2009, Danny Backx wrote:
> > On Sun, 2009-08-23 at 18:18 +0200, Vincent Torri wrote:
> >> in io.h, shouldn't struct _finddata_t be guarded by _FINDDATA_T_DEFINED
> >> (like _fsize_t is guarded by _FSIZE_T_DEFINED) ?
> >>
> >> Vincent Torri
> >
> > I guess so. Mingw doesn't appear to have this though. Does this bother
> > you or is it a cosmetic question ?
>
> It bother me a bit. It is for the compilation of Lua for Windows CE (Yes
> it is possible !!). Indeed, the guy wrote some code to allow the
> compilation of Lua on that OS, and used _FINDDATA_T_DEFINED around the
> structure. Hence double definition of the structure when compiling.
>
> Even it is not a problem for Lua on win32, I'll report that to the MinGW
> devs.

I'll fix it.

I see that you've reported it to MinGW too - very good !

        Danny
--
Danny Backx ; danny.backx - at - scarlet.be ; http://danny.backx.info


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Cegcc-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/cegcc-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: about definition of struct _finddata_t

Vincent Torri


On Wed, 26 Aug 2009, Danny Backx wrote:

> On Wed, 2009-08-26 at 11:35 +0200, Vincent Torri wrote:
>> On Tue, 25 Aug 2009, Danny Backx wrote:
>>> On Sun, 2009-08-23 at 18:18 +0200, Vincent Torri wrote:
>>>> in io.h, shouldn't struct _finddata_t be guarded by _FINDDATA_T_DEFINED
>>>> (like _fsize_t is guarded by _FSIZE_T_DEFINED) ?
>>>>
>>>> Vincent Torri
>>>
>>> I guess so. Mingw doesn't appear to have this though. Does this bother
>>> you or is it a cosmetic question ?
>>
>> It bother me a bit. It is for the compilation of Lua for Windows CE (Yes
>> it is possible !!). Indeed, the guy wrote some code to allow the
>> compilation of Lua on that OS, and used _FINDDATA_T_DEFINED around the
>> structure. Hence double definition of the structure when compiling.
>>
>> Even it is not a problem for Lua on win32, I'll report that to the MinGW
>> devs.
>
> I'll fix it.
>
> I see that you've reported it to MinGW too - very good !

I think that the same stuff is missing for struct timezone in sys/time.h

Vicent Torri

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Cegcc-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/cegcc-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: about definition of struct _finddata_t

Danny Backx
On Wed, 2009-08-26 at 20:26 +0200, Vincent Torri wrote:
> I think that the same stuff is missing for struct timezone in sys/time.h

Something like this ?

        Danny

pavilion: {1014} svn diff sys/time.h
Index: sys/time.h
===================================================================
--- sys/time.h  (revision 1227)
+++ sys/time.h  (working copy)
@@ -23,11 +23,14 @@
 /* Provided for compatibility with code that assumes that
    the presence of gettimeofday function implies a definition
    of struct timezone. */
+#ifndef _TIMEZONE_DEFINED
 struct timezone
 {
   int tz_minuteswest; /* of Greenwich */
   int tz_dsttime;     /* type of dst correction to apply */
 };
+#define _TIMEZONE_DEFINED
+#endif
 
 /*
    Implementation as per:
pavilion: {1015}
--
Danny Backx ; danny.backx - at - scarlet.be ; http://danny.backx.info


------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Cegcc-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/cegcc-devel
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: about definition of struct _finddata_t

Vincent Torri


On Wed, 26 Aug 2009, Danny Backx wrote:

> On Wed, 2009-08-26 at 20:26 +0200, Vincent Torri wrote:
>> I think that the same stuff is missing for struct timezone in sys/time.h
>
> Something like this ?

yes, exactly

Vincent Torri

>
> Danny
>
> pavilion: {1014} svn diff sys/time.h
> Index: sys/time.h
> ===================================================================
> --- sys/time.h  (revision 1227)
> +++ sys/time.h  (working copy)
> @@ -23,11 +23,14 @@
> /* Provided for compatibility with code that assumes that
>    the presence of gettimeofday function implies a definition
>    of struct timezone. */
> +#ifndef _TIMEZONE_DEFINED
> struct timezone
> {
>   int tz_minuteswest; /* of Greenwich */
>   int tz_dsttime;     /* type of dst correction to apply */
> };
> +#define _TIMEZONE_DEFINED
> +#endif
>
> /*
>    Implementation as per:
> pavilion: {1015}
> --
> Danny Backx ; danny.backx - at - scarlet.be ; http://danny.backx.info
>
>
> --
> Ce message a été vérifié par MailScanner
> pour des virus ou des polluriels et rien de
> suspect n'a été trouvé.
> Message délivré par le serveur de messagerie de l'Université d'Evry.
>
>
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.  http://p.sf.net/sfu/bobj-july
_______________________________________________
Cegcc-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/cegcc-devel
Loading...