Upstreaming patches

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Upstreaming patches

Paul Sokolovsky
Hello,

As if heavens select good time to add a bit of controversy, I've just
got reply from upstream for the patch I just couldn't drop silently in
my cleanup (and also it was kind of poke at them if they actually
process patches):

https://sourceforge.net/tracker/index.php?func=detail&aid=3139241&group_id=2435&atid=302435

Well, will be a good test case for how well git cvsimport works ;-).

And they're there and reasonably responsive. There're two other patches
which I did clean up from my branch (as they are not directly related to
real wince functionality, so should not be subject of maintenance for
wince cross-compiler):

https://github.com/pfalcon/cegcc-w32api-try1/commit/c66d8ab22bb44287c48a1f46349bb0ca514cae8f
https://github.com/pfalcon/cegcc-w32api-try1/commit/dba53b839e04067d0ed319b61e9e61a3b24bd544

Anybody bothers to submit them?

Note 1: these are reverse patches (i.e. once forward patch was applied
to upstream, I applied reverse patch to bring it back to upstream).
Note 2: if you'll submit dba53b839e, note that hex conversion for
PSH_WATERMARK is wrong. Which should be another hint why any changes to
upstream should be minimal, if not avoided.


--
Best regards,
 Paul                          mailto:[hidden email]

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Cegcc-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/cegcc-devel
Reply | Threaded
Open this post in threaded view
|

Re: Upstreaming patches

Vincent Torri


On Mon, 27 Dec 2010, Paul Sokolovsky wrote:

> https://github.com/pfalcon/cegcc-w32api-try1/commit/dba53b839e04067d0ed319b61e9e61a3b24bd544

-#define PSH_MAXIMIZE    0x2000  /* ?? */

1) Why is there such comment ?
2) maybe you should let the comment in the code, even with a FIXME

Vincent Torri

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Cegcc-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/cegcc-devel
Reply | Threaded
Open this post in threaded view
|

Re: Upstreaming patches

Paul Sokolovsky
Hello,

On Tue, 28 Dec 2010 10:43:13 +0100 (CET)
Vincent Torri <[hidden email]> wrote:

>
>
> On Mon, 27 Dec 2010, Paul Sokolovsky wrote:
>
> > https://github.com/pfalcon/cegcc-w32api-try1/commit/dba53b839e04067d0ed319b61e9e61a3b24bd544
>
> -#define PSH_MAXIMIZE    0x2000  /* ?? */
>
> 1) Why is there such comment ?

Ask Danny, that was his commit.

> 2) maybe you should let the comment in the code, even with a FIXME

Well, I'm doing mindful, attentive cleanup, not just dumb cut&pasting.
I cannot pledge to have scrutinized every changed line (there're 100Kb
after all), but that's essentially what I do for every small hunk -
either get rid of a change line in it, or justify it's necessity (and
that's b@tchy job, can't believe I volunteered for that ;-)). In this
case I verified that the value seems correct (using multi-score method
described in yesterday's mail), and as that apparently can be the only
question for a simple define, removed a mark.

>
> Vincent Torri



--
Best regards,
 Paul                          mailto:[hidden email]

------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Cegcc-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/cegcc-devel
Reply | Threaded
Open this post in threaded view
|

Re: Upstreaming patches

Danny Backx
In reply to this post by Paul Sokolovsky
Read the value in an article somewhere, insufficiently verified.

 Danny

> -#define PSH_MAXIMIZE    0x2000  /* ?? */
>
> 1) Why is there such comment ?

Ask Danny, that was his commit.

[hidden email] - http://danny.backx.info
Verzonden van mijn HTC




------------------------------------------------------------------------------
Learn how Oracle Real Application Clusters (RAC) One Node allows customers
to consolidate database storage, standardize their database environment, and,
should the need arise, upgrade to a full multi-node Oracle RAC database
without downtime or disruption
http://p.sf.net/sfu/oracle-sfdevnl
_______________________________________________
Cegcc-devel mailing list
[hidden email]
https://lists.sourceforge.net/lists/listinfo/cegcc-devel